Ticket #341 (closed defect: fixed)

Opened 1 year ago

Last modified 1 month ago

All downloaded data deleted on timeout error

Reported by: Degenerate Assigned to:
Priority: critical Milestone:
Component: Downloads Version: 1.0b2
Keywords: timeout Cc:
Operating System: All

Description

I've been trying to download a file of about 1GB from a server that supports resuming. First attempt was with 1.0b1. Got to about 350MB, then timed out. Upon timeout, the completion column went to 0% and looking in the temp dir showed the file had already been deleted - so there was nothing to resume.

Upgraded to 1.0b2 and tried again. This time it got to 850MB before timing out. Again, the completion went straight to 0% and the partial file disappeared from the temp dir. This time I clicked resume anyway. File restarted from beginning, ran for a short while then threw a "size mismatch" error. Back to 0% and no temp file again. Another attempt gave the same result - this time it got to about 100MB before "size mismatch" and all data deleted.

I've marked this critical, as I consider the loss of large amounts of downloaded data a serious problem.

Attachments

dta_log.zip (2.1 kB) - added by Degenerate on 10/17/07 01:52:00.
DTA Log (zipped)

Change History

09/13/07 06:55:08 changed by ant

3. When you report a bug, try to be as much accurate as you can. You have to specify:

  1. DownThemAll! and Firefox version numbers
  2. Your operating system
  3. A step-by-step list of the actions that cause the problem
  4. You should also attach a DiagnosticLog helping us to diagnose the problem.

09/13/07 20:34:10 changed by Degenerate

Requested info:

DTA 1.0b2 on Firefox 2.0.0.6 on Ubuntu Feisty.

I will have a go at reproducing this with a diagnostic log.

09/15/07 21:13:12 changed by MaierMan

I recently had some over-night downloads which timed out (my home router simply crashed unnoticed by the OS). These files were correctly paused and we're resumable...

The behavior on timeout is:

  • Resumable: pause the download
  • Non-Resumable: cancel the download, which will effectively delete the already retrieved data (there is no point in keeping half-finished data).

I'd really like to see some diagnostic logs (or some URLs so that I can reproduce myself) to see if there is indeed a bug with this. ;)

09/17/07 02:26:27 changed by Degenerate

I haven't had an opportunity to reproduce it yet. It's only happened with large files. Other files have timed out and been resumable. I should add that my connection is suffering from high packet loss, which may well have something to do with it.

The "by design" behavior you describe explains a lot. I'm sure that the problem is due to the files being incorrectly marked as non-resumable, despite the fact that the server in question definately supports resume. Could an incident of packet loss cause DTA to think a file is non-resumable? I think it is a mistake for DTA to delete the data when it decides a file is non-resumable. It should just pause the download and allow the user, who may know better, another chance to resume.

10/16/07 14:04:03 changed by Degenerate

I have now reproduced this with a log. I attempted to attach it to this ticket but got the following error:

"Submission rejected as potential spam (Maximum number of external links per post exceeded, Akismet says content is spam)"

10/17/07 01:52:00 changed by Degenerate

  • attachment dta_log.zip added.

DTA Log (zipped)

10/17/07 01:55:37 changed by Degenerate

I've put the log in a zip file to get around the problem.

This was just as above - several "size mismatch" errors, then it failed to resume and deleted the file.

11/05/07 14:33:34 changed by MaierMan

  • status changed from new to closed.
  • resolution set to wontfix.

The log says the server changed the Etag. This basicially means that the resource for given URI changed in between.

dTa considers this a hard-failure and aborts the download.

However you got likely hit by the apache inode/IIS token load balancer "problem". We worked around this by now.

Corresponding changeset is [635].

I will resolve this wontfix (instead of fixed) as I cannot determine if it was indeed said problem above (which would make this report "fixed") or if the server really changed the resource in between (which would be "wontfix").

08/01/08 16:30:37 changed by dmaster97

  • status changed from closed to reopened.
  • resolution deleted.

i happened to experience this error almost everytime i use a dialup. unfortunately, dialup isps almost always use a proxy to increase response. this make dta not suitable for dialups. but, apparently disabling multipart will help alot. at least, when the download timeout, it can continue without reseting the download.

a like the old dta pre version 1. it least susceptible to dialup connection.

08/01/08 16:38:46 changed by MaierMan

  • status changed from reopened to closed.
  • resolution set to fixed.