Ticket #327 (closed defect: fixed)

Opened 3 years ago

Last modified 1 year ago

A solution to prefwindow resizement problems.

Reported by: stefano.verna Assigned to:
Priority: major Milestone: 1.0
Component: User Interface Version: ---
Keywords: Cc:
Operating System: All

Description

From babelzilla DTA forum...

I already figured there would be some size issues with the preferences. Hence I'm waiting for reports of all localizers to see how we have to change the window dimensions. Auto-resizing sadly is not really an option; it simply won't work correctly for (our) prefwindow.

You can find some methods to achieve this in the BZ-forum. One of them is to put two entities in the locales, which can be filled by the translators with the height and width of the window in their specific language. I'm not a coder, but ask Goofy in this forum for help. He posted this method several times in the forum.

I think this is the right way to go, never thought about it.

Change History

(follow-up: ↓ 4 ) 2007-09-04 20:48:04 changed by MaierMan

  • milestone set to 1.0.

Yep, this should work best, and actually is what FX does itself:

style="&prefWindow.styleWin;">

(follow-up: ↓ 8 ) 2007-09-04 23:35:09 changed by MaierMan

Committed [590].

This needs verification that it does not break mac ;)

2007-09-04 23:54:29 changed by MaierMan

*** Ticket #324 marked duplicate of this one ***

(in reply to: ↑ 1 ; follow-up: ↓ 5 ) 2007-09-05 00:59:12 changed by Teo

Replying to MaierMan:

Yep, this should work best, and actually is what FX does itself: {{{ style="&prefWindow.styleWin;"> }}}

This is no good solution. This is solution proposed by me on BabelZilla?.

Can you test mine solution window size problem? If yes, follow instruction: 1. From original chrome.manifest file remove line 52 2. From chrome\dta.jar\skin\win\ directory remove preferences.css file. If you working on Linux, remove the same file from 'unix' directory. 3. From chrome\dta.jar\content\preferences\ directory remove all files except prefs.js and seamonkey.xul and copy to this directory attached file

Now all panes in the options window should matching to content. Please report me about your remarks. See here:http://www.babelzilla.org/forum/index.php?showtopic=1691&pid=33027&st=120&_entry32856

(in reply to: ↑ 4 ; follow-up: ↓ 6 ) 2007-09-05 01:32:45 changed by MaierMan

Replying to Teo:

This is no good solution. ...

This is the best solution.
Furthermore it is the way Firefox does it. http://mxr.mozilla.org/mozilla1.8/source/browser/components/preferences/preferences.xul#78

put-all-into-a-single-xul/sizeToContent() OTOH doesn't work correctly and breaks MacOS.
Oh, and of course you have to put all the stuff into a single xul, what I strongly dislike.

(in reply to: ↑ 5 ; follow-up: ↓ 7 ) 2007-09-05 02:28:34 changed by Teo

Replying to MaierMan:

This is the best solution.

This is your opinion. IMHO this only simple way. Simple solution add entity and translator will be matching content...

Furthermore it is the way Firefox does it.

It's very old way, but very simply.

put-all-into-a-single-xul/sizeToContent() OTOH doesn't work correctly and breaks MacOS.

Do you checked mine file on Mac?

Oh, and of course you have to put all the stuff into a single xul, what I strongly dislike.

I like. Prefwindow is special window and all code must be written properly, developer have to know all issues this window kind, but all stuff in the single window working together, in the separated window working separately and have to be used constant width and height which is not good for many languages. IMHO developer should write code thus that end user or translator shouldn't anything doing with window size. Window should matching to content automatically.

(in reply to: ↑ 6 ) 2007-09-05 03:00:06 changed by MaierMan

Replying to Teo:

Replying to MaierMan:

This is the best solution.

This is your opinion. IMHO this only simple way. Simple solution add entity and translator will be matching content...

And since I'm one of the developers my opinion matters a lot ;)

Furthermore it is the way Firefox does it.

It's very old way, but very simply.

You do recognize that this is way was chosen intentionally by Ben when he implemented the prefwindow?
Futhermore:

This effect, btw, can be seen in older dTa versions ;)

put-all-into-a-single-xul/sizeToContent() OTOH doesn't work correctly and breaks MacOS.

Do you checked mine file on Mac?

Did you?
I don't have a mac available actually, but I know that the mac has a fancy animated resize effect (height only) that breaks because of sizeToContent() or hard-coded height.

Oh, and of course you have to put all the stuff into a single xul, what I strongly dislike.

I like. Prefwindow is special window and all code must be written properly, developer have to know all issues this window kind, but all stuff in the single window working together, in the separated window working separately and have to be used constant width and height which is not good for many languages. IMHO developer should write code thus that end user or translator shouldn't anything doing with window size. Window should matching to content automatically.

In and ideal world this might be true. However as it is there is no reliable way to do such auto-resizes, so I settle with the "default" method.

(in reply to: ↑ 2 ; follow-up: ↓ 9 ) 2007-09-05 07:43:09 changed by stefano.verna

Replying to MaierMan:

Committed [590]. This needs verification that it does not break mac ;)

Will check it in the morning.

(in reply to: ↑ 8 ) 2007-09-06 22:58:51 changed by MaierMan

Replying to stefano.verna:

Replying to MaierMan:

Committed [590]. This needs verification that it does not break mac ;)

Will check it in the morning.

If it works then please resolve as fixed.

2007-09-07 07:57:10 changed by stefano.verna

  • status changed from new to closed.
  • resolution set to fixed.