Ticket #250 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

escape character in filename not replaced with a legal character to save to windows system

Reported by: bugMagnet Assigned to:
Priority: major Milestone: 1.0
Component: Downloads Version: 0.9.9.10
Keywords: Cc:
Operating System: Windows

Description

using: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4 DTA v 0.9.9.10

problem page: http://www.davidrovics.com/kids/songChest.php

left click then select (*) DownThemAll & [OK]

while the rest worked with DTA, these 3 failed to download with 'file access error':

http://www.davidrovics.com/kids/songChest.php?dnl=8 http://www.davidrovics.com/kids/music/daddy%5C's_camper_van.mp3

http://www.davidrovics.com/kids/songChest.php?dnl=12 http://www.davidrovics.com/kids/music/i%5C'm_so_tired_of_being_in_this_car.mp3

http://www.davidrovics.com/kids/songChest.php?dnl=15 http://www.davidrovics.com/kids/music/i_don%5C't_wanna_grow_up.mp3

the file data was completely transferred, the progress bar proceeded to 100% smoothly, but then the write failed since the "\" is illegal in win filenames. firefox code changes that to a legal character to 'save as'.

direct save to disk works, as firefox substitutes a "-" for the "\" produced by the %5C code in the filename.

I ahare files from my win systems that have an apostrophe in the filename without issues. I am not sure why the webmaster on this site decided the escape character \ code was needed. maybe its a linux thang

DTA error log:

19:07:05:540

Let's start daddy\'s_camper_van.mp3

19:07:05:540

http://www.davidrovics.com/kids/music/daddy%5C's_camper_van.mp3 (http://www.davidrovics.com/kids/songChest.php): getHeader()

19:07:05:590

ChunkElement?: 0/0

19:07:05:590

daddy\'s_camper_van.mp3: Created Header Chunk Test (0-0)

19:07:05:760

First ProgressChange? for chunk C:\WINDOZE\TEMP\dta\dtatempfile1184018826613.part0!

19:07:05:760

acceptrange = bytes

19:07:05:760

daddy\'s_camper_van.mp3: Test Header Chunk started

19:07:05:760

daddy\'s_camper_van.mp3: Multipart downloading is not needed/possible. isResumable = true

19:07:05:760

checkFilenameConflict(): Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsILocalFile.append] (undefined line 590)

19:07:13:560

daddy\'s_camper_van.mp3: Chunk 0-1770335 finished.

19:07:13:610

joinListener created for #daddy\'s_camper_van.mp3

19:07:13:610

daddy\'s_camper_van.mp3: Download is completed!

19:07:13:610

joinListener: closeStream [dtatempfile1184018826613.part0]

19:07:13:610

daddy\'s_camper_van.mp3: Move C:\WINDOZE\TEMP\dta\dtatempfile1184018826613.part0 to D:\! MP3s !\David Rovics\David Rovics - 4 Kids - daddy\'s_camper_van.mp3

19:07:13:610

checkFilenameConflict(): Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsILocalFile.append] (undefined line 590)

19:07:13:780

daddy\'s_camper_van.mp3: cancelDownload()

19:07:13:780

download::moveCompleted: Could not move file or create directory: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.moveTo] (undefined line 373)

Change History

2007-07-11 22:23:41 changed by MaierMan

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone set to 1.0.

worksforme beta1/nightly

Seems the charset override code works.